Fix / Significant Balance Decrease Banner #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse from debug_traceCall (token discovery logic). If debug_traceCall fails or its response is delayed, we show `PossibleBalanceDecrease` banner, in place of `SignificantBalanceDecrease`.
… a new request is added to an existing AccOp. Previously, we invoked it only on initialization at the frontend level. However, for earlier invocation and improved reliability, we will now invoke it as early as possible in the background - both on initialization and when a new request is added.
…dition with timeout in `main.traceCall`.
PetromirDev
requested changes
Feb 12, 2025
|
@jordan-enev can we please increase the 2 secs to 5 secs |
|
@Ivshti @jordan-enev In my opinion, if we decide to increase the timeout there should be some sort of loading state or warning that we are not sure if the user's balance will decrease substantially. I'm not a degen by any means and don't operate with large amounts but I don't take too much time on the sign account op screen- it loads, I scan everything, select a fee speed and sign, which may take less than 5 seconds. This problem is still present but not that prominent with a 2-second timeout. |
|
ok @PetromirDev then I agree with two secs |
Ivshti
approved these changes
Feb 13, 2025
borislav-itskov
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/AmbireTech/ambire-app/issues/3821.
The problem:
When we perform a SWAP (or any other activity that results in a new portfolio token), the BalanceDecreaseBanner was shown if the output token was new to the portfolio. This happened because the newly acquired token hadn't yet been added to the portfolio through our learning/discovery process.
To fix this, we introduced a new flag called
traceCallDiscoveryStatus, which tracks whether the discovery logic has been completed.How we fixed it:
traceCallcompletes successfully within 2 seconds and there is a significant balance decrease, we display the regular banner. (Screenshot attached)traceCalltakes more than 2 seconds to respond or fails, we display a similar banner indicating that the balance may decrease, but we can't be certain due to temporary issues with the token discovery logic. (Screenshot attached)traceCallis slow to respond, the second banner will be shown initially, and once resolved, the main banner will be displayed.Significant Account Balance Decrease (traceCall completes successfully)
Significant Account Balance Decrease (Possibly Inaccurate) (traceCall fails or it's slow)
