Skip to content

Search by keyword problems#607

Merged
eslam-99 merged 2 commits into
developfrom
fix/search-by-keyword-problems
Aug 19, 2025
Merged

Search by keyword problems#607
eslam-99 merged 2 commits into
developfrom
fix/search-by-keyword-problems

Conversation

@ThoriaHamdy99

Copy link
Copy Markdown
Contributor

Description

  • Resolve 2 UI problems in search by keyword.

Changes Made

  • Resolve state while clicking on any recent search to be loading at first instead on no search placeholder
  • Resolve the recent searches flashes while typing spaces on the search text field

Screenshots

BeforeAfter
recent_searches_problem.mp4
recent_searches_problem_done.mp4
BeforeAfter
placeholder_state_problem.mp4
placeholder_state_problem_done.mp4

Checklist

  • My code follows the code style of this project
  • Changes have been tested manually and verified.
  • PR includes at most one single feature.

@github-actions

Copy link
Copy Markdown

📊 domain Test Results

226 tests   226 ✅  3s ⏱️
 70 suites    0 💤
 70 files      0 ❌

Results for commit 9d1e8dc.

@github-actions

Copy link
Copy Markdown

📊 remoteDatasource Test Results

 16 files   16 suites   6s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
252 runs  252 ✅ 0 💤 0 ❌

Results for commit 9d1e8dc.

@github-actions

Copy link
Copy Markdown

📊 localDatasource Test Results

 20 files   20 suites   9s ⏱️
 71 tests  71 ✅ 0 💤 0 ❌
142 runs  142 ✅ 0 💤 0 ❌

Results for commit 9d1e8dc.

@github-actions

Copy link
Copy Markdown

📊 viewModel Test Results

 40 files   40 suites   9s ⏱️
261 tests 251 ✅ 10 💤 0 ❌
522 runs  502 ✅ 20 💤 0 ❌

Results for commit 9d1e8dc.

@github-actions

Copy link
Copy Markdown

🛡️ Total Code Coverage Report

Total Project Coverage 95.66%

@eslam-99 eslam-99 merged commit ad25a96 into develop Aug 19, 2025
6 checks passed
@eslam-99 eslam-99 deleted the fix/search-by-keyword-problems branch August 19, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants