Skip to content

Fix rating stars spacing #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThoriaHamdy99 merged 2 commits into from
Aug 19, 2025
Merged

Fix rating stars spacing #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0570e
fix: set rating stars spacing as fixed
eslam-99 Aug 19, 2025
828883d
fix: fix stars size on small screens
eslam-99 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/main/java/com/amsterdam/ui/components/RatingBar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ fun RatingBar(
modifier =
Modifier
.size(starSize)
.then(if (useEqualSpacing) Modifier.weight(1f) else Modifier)
.weight(1f)
.graphicsLayer(translationY = translateY.value)
.clickable(
onClick = { onRatingStarChanged(starIndex) },
Expand Down
1 change: 1 addition & 0 deletions ui/src/main/java/com/amsterdam/ui/components/movieAndTvShowDetails/RateDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ fun RateDialog(
modifier = Modifier.padding(bottom = 24.dp),
selectedStarIndex = selectedStarIndex,
onRatingStarChanged = interaction::onChangeRating,
useEqualSpacing = false
)

ConfirmButton(
Expand Down
1 change: 1 addition & 0 deletions .../java/com/amsterdam/ui/screens/search/keywordSearch/sections/filterDialog/FilterDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ internal fun FilterDialog(
modifier = Modifier.padding(top = 8.dp, bottom = 12.dp),
selectedStarIndex = filterState.selectedStarIndex,
onRatingStarChanged = interaction::onChangeRatingStar,
useEqualSpacing = false
)
Text(
text = stringResource(R.string.genre),
Expand Down