Skip to content

Fix/add to list#610

Merged
mohamedd-hassan merged 4 commits into
developfrom
fix/add-to-list
Aug 19, 2025
Merged

Fix/add to list#610
mohamedd-hassan merged 4 commits into
developfrom
fix/add-to-list

Conversation

@mohamedd-hassan

Copy link
Copy Markdown
Contributor

Pull Request Template

Description

fixed add to list dialog to scroll it with if there are a lot of lists, and fixed updating count when adding new list


Changes Made

List the changes introduced in this pull request:

  • Added New function to update ui state with new count
  • changed list items to normal column instead of lazy column

Screenshots (if applicable)

addToList.mp4

Checklist

Please ensure the following tasks are completed:

  • My code follows the code style of this project
  • Changes have been tested manually and verified.
  • PR includes at most one single feature.

Additional Comments

Add any additional information or context about the pull request here.

@github-actions

Copy link
Copy Markdown

📊 domain Test Results

226 tests   226 ✅  3s ⏱️
 70 suites    0 💤
 70 files      0 ❌

Results for commit d11b353.

@github-actions

Copy link
Copy Markdown

📊 remoteDatasource Test Results

 16 files   16 suites   6s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
252 runs  252 ✅ 0 💤 0 ❌

Results for commit d11b353.

@github-actions

Copy link
Copy Markdown

📊 localDatasource Test Results

 20 files   20 suites   10s ⏱️
 71 tests  71 ✅ 0 💤 0 ❌
142 runs  142 ✅ 0 💤 0 ❌

Results for commit d11b353.

@github-actions

Copy link
Copy Markdown

📊 viewModel Test Results

 40 files   40 suites   10s ⏱️
260 tests 250 ✅ 10 💤 0 ❌
520 runs  500 ✅ 20 💤 0 ❌

Results for commit d11b353.

@github-actions

Copy link
Copy Markdown

🛡️ Total Code Coverage Report

File Coverage [100.00%]
viewModel/src/main/java/com/amsterdam/viewmodel/movieDetails/MovieDetailsViewModel.kt 100.00%
Total Project Coverage 95.69%

@mohamedd-hassan mohamedd-hassan merged commit 6cc1385 into develop Aug 19, 2025
6 checks passed
@mohamedd-hassan mohamedd-hassan deleted the fix/add-to-list branch August 19, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants