fix: remove vertical padding from app bar in MovieDetailsScreen#614
Merged
Conversation
This commit removes the `vertical = 8.dp` padding from the `DefaultAppBar` within the `MovieDetailsScreen`. The horizontal padding of `16.dp` remains.
Noor-Serry
requested review from
Ahmed-AlMancy,
Asiasama710,
Belal-Alkhatib,
Pixelh97,
ahmedmahgoub0,
eslam-99,
marah222,
mohamedd-hassan,
monaayman123,
nabilBouzineDev and
saraashraf11
📊 domain Test Results226 tests 226 ✅ 3s ⏱️ Results for commit ac58306. |
📊 localDatasource Test Results 20 files 20 suites 10s ⏱️ Results for commit ac58306. |
📊 remoteDatasource Test Results 16 files 16 suites 6s ⏱️ Results for commit ac58306. |
📊 viewModel Test Results 40 files 40 suites 9s ⏱️ Results for commit ac58306. |
🛡️ Total Code Coverage Report
|
eslam-99
approved these changes
Aug 20, 2025
monaayman123
approved these changes
Aug 20, 2025
mohamedd-hassan
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
vertical = 8.dppadding from theDefaultAppBarwithin theMovieDetailsScreen. The horizontal padding of16.dpremains.Pull Request Template
Description
Provide a clear and concise description of what this pull request does. Include the purpose and context for the changes.
Changes Made
List the changes introduced in this pull request:
Screenshots (if applicable)
Include screenshots or GIFs to showcase the changes, especially if they impact the UI.
Checklist
Please ensure the following tasks are completed:
Additional Comments
Add any additional information or context about the pull request here.