Skip to content

Refactor: Centralized Server-Side Error Handling with Clean Client Responses (Fixes #15) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajashre-e wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor: Centralized Server-Side Error Handling with Clean Client Responses (Fixes #15) #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 29 additions & 13 deletions controllers/songController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,51 @@
const db = require('../db');
const db = require("../db");

// Introduced centralized error handling to log detailed
// server errors and return a consistent, generic message to the client

function handleServerError(res, err) {
console.error("[SERVER ERROR]", err);
res.status(500).json({ error: "Internal Server error" });
}

exports.getSongs = (req, res) => {
db.all('SELECT * FROM songs', (err, rows) => {
if (err) return res.status(500).json({ error: err.message });
db.all("SELECT * FROM songs", (err, rows) => {
if (err) return handleServerError(res, err);
res.json(rows);
});
};

exports.addSong = (req, res) => {
const { title, artist, genre } = req.body;

if (!title || !artist || !genre) {
return res.status(400).json({ error: 'Missing song fields' });
return res.status(400).json({ error: "Missing required song fields" });
}

db.run('INSERT INTO songs (title, artist, genre) VALUES (?, ?, ?)', [title, artist, genre], function (err) {
if (err) return res.status(500).json({ error: err.message });
res.status(201).json({ id: this.lastID, title, artist, genre });
});
db.run(
"INSERT INTO songs (title, artist, genre) VALUES (?, ?, ?)",
[title, artist, genre],
function (err) {
if (err) return handleServerError(res, err);
res.status(201).json({ id: this.lastID, title, artist, genre });
}
);
};

exports.getPlaylists = (req, res) => {
db.all('SELECT * FROM playlists', (err, rows) => {
if (err) return res.status(500).json({ error: err.message });
db.all("SELECT * FROM playlists", (err, rows) => {
if (err) return handleServerError(res, err);
res.json(rows);
});
};

exports.createPlaylist = (req, res) => {
const { name } = req.body;
if (!name) return res.status(400).json({ error: 'Playlist name is required' });
if (!name)
return res.status(400).json({ error: "Playlist name is required" });

db.run('INSERT INTO playlists (name) VALUES (?)', [name], function (err) {
if (err) return res.status(500).json({ error: err.message });
db.run("INSERT INTO playlists (name) VALUES (?)", [name], function (err) {
if (err) return handleServerError(res, err);
res.status(201).json({ id: this.lastID, name });
});
};