Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Type mismatch in the <Track>.raw property #1930

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Fix: Type mismatch in the <Track>.raw property #1930

merged 3 commits into from
Aug 3, 2024

Conversation

retrouser955
Copy link
Collaborator

Changes

Fixes .raw being typed RawTrackData and export .live property from .raw

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

@vercel Vercel
Copy link

vercel bot commented Aug 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-player-website ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2024 6:33am

@retrouser955 retrouser955 marked this pull request as draft August 3, 2024 06:24
@retrouser955
Copy link
Collaborator Author

@twlite Do you think setting .raw as Record<string, any> is better than the plain any?

@retrouser955 retrouser955 changed the title Track-type-fix Fix: Type mismatch in the <Track>.raw property Aug 3, 2024
@retrouser955 retrouser955 linked an issue Aug 3, 2024 that may be closed by this pull request
Type mismatch in the raw track objects #1926
Closed
@retrouser955 retrouser955 added the area:main Related to discord-player label Aug 3, 2024
@retrouser955 retrouser955 requested a review from twlite August 3, 2024 06:50
@retrouser955 retrouser955 marked this pull request as ready for review August 3, 2024 06:50
twlite
twlite approved these changes Aug 3, 2024
View reviewed changes
Copy link
Collaborator

@twlite twlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@twlite twlite merged commit 434d1f2 into stable Aug 3, 2024
4 checks passed
@twlite twlite deleted the track-type-fix branch August 3, 2024 07:01
@VicDario VicDario mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twlite twlite twlite approved these changes

Assignees
No one assigned
Labels
area:main Related to discord-player
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type mismatch in the raw track objects
2 participants
@retrouser955 @twlite