Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Navbar UI #243

Closed
wants to merge 3 commits into from
Closed

Improved Navbar UI #243

wants to merge 3 commits into from

Conversation

somil0701
Copy link

Description

  • I've updated the Navbar UI by setting the color of the navbar in order to sync with the color theme of this website.
  • Made changes to the width of the navbar as well as some margin/padding to make it soothing
  • Fixed the bug related to scrolling where the transparent navbar was not looking good.

Related Issues

  • Closes #

Type of PR

  • ()

Screenshots / videos (if applicable)

Old UI:
image

New UI:
image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @somil0701! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit e609502
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/670bc65f5598b0000923cd1e
😎 Deploy Preview https://deploy-preview-243--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@somil0701
Copy link
Author

Hi @Anjaliavv51 , I've made the UI changes to the navbar as assigned earlier. Please review the PR and assign the level according to it.
Thank You :)

@Anjaliavv51
Copy link
Owner

@somil0701 match the color with before navbar color

@somil0701
Copy link
Author

@somil0701 match the color with before navbar color

@Anjaliavv51 can you please elaborate which part of color are you talking about with ss(if possible)?

@Anjaliavv51
Copy link
Owner

@somil0701 please rectify the below

image

@somil0701
Copy link
Author

@somil0701 please rectify the below

image

@Anjaliavv51 Sure! I'll check out the navbar from other pages too. Please confirm the color scheme of the navbar as you mentioned earlier if you want it to be changed.

@somil0701
Copy link
Author

@Anjaliavv51 I've fixed the navbar for other pages as well which was earlier not working as expected, please review it and confirm so that I can send a PR.
Thank You :)
image
image
image
image

@somil0701
Copy link
Author

@Anjaliavv51 Please check the above suggestions and update regarding to it if possible

@Anjaliavv51
Copy link
Owner

@somil0701 resolve the conflicts.

@somil0701
Copy link
Author

@Anjaliavv51 I've resolved the conflicts please look towards it and merge the PR.
Issue Number Reference: #236
Thank You :)

@Anjaliavv51
Copy link
Owner

@somil0701 go through the below image from ur deploy , right side of navbar is not aligned properly.

image

2004shweta pushed a commit to 2004shweta/Retro that referenced this pull request Oct 15, 2024
[feature]: added auto sliding feature in testimonial section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants