Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#240 solved✨ #247

Merged
merged 3 commits into from
Oct 6, 2024
Merged

issue#240 solved✨ #247

merged 3 commits into from
Oct 6, 2024

Conversation

trahulprabhu38
Copy link
Contributor

Description

  • solved the problem with the CSS of the signup pages.
  • removed some inline css as it slows the whole page .
  • the local Storage is working.

Type of PR

  • Feature Enhancement

Screenshots / videos (if applicable)

Screenshot 2024-10-05 at 11 41 17 PM Screenshot 2024-10-05 at 11 42 52 PM Screenshot 2024-10-05 at 11 43 09 PM Screenshot 2024-10-05 at 11 50 21 PM

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @T-Rahul-prabhu-38! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@trahulprabhu38
Copy link
Contributor Author

trahulprabhu38 commented Oct 5, 2024

@Anjaliavv51 please check this , and can u add the level as well please.As i worked on multiple pages and added local storage aswell , will this be good enough to be considered as level 3.

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 124c2d8
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/67023c33571396000850a11d
😎 Deploy Preview https://deploy-preview-247--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51
Copy link
Owner

@T-Rahul-prabhu-38 donot make any change in css , please remove ur css.

@Anjaliavv51 Anjaliavv51 added enhancement New feature or request good first issue Good for newcomers gssoc-ext Level 1 hacktoberfest-accepted and removed good first issue Good for newcomers labels Oct 6, 2024
@Anjaliavv51 Anjaliavv51 merged commit 6a660ec into Anjaliavv51:main Oct 6, 2024
6 checks passed
Copy link

github-actions bot commented Oct 6, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@trahulprabhu38
Copy link
Contributor Author

@Anjaliavv51 since i made lot of changes can it be level 2 atleast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants