Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added dark mode button #340

Merged
merged 4 commits into from
Oct 15, 2024
Merged

added dark mode button #340

merged 4 commits into from
Oct 15, 2024

Conversation

priyashuu
Copy link
Contributor

Description

Related Issues

Type of PR

  • ()

Screenshots / videos (if applicable)

image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

github-actions[bot]
github-actions bot reviewed Oct 8, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @priyashuu! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@netlify Netlify
Copy link

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 1aef4f0
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/670cb346c6132d000833fa7c
😎 Deploy Preview https://deploy-preview-340--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@priyashuu priyashuu mentioned this pull request Oct 8, 2024
Closed
4 tasks
@priyashuu
Copy link
Contributor Author

@Anjaliavv51 can you please reveiew it and merge it

3 similar comments
@priyashuu
Copy link
Contributor Author

@Anjaliavv51 can you please reveiew it and merge it

@priyashuu
Copy link
Contributor Author

@Anjaliavv51 can you please reveiew it and merge it

@priyashuu
Copy link
Contributor Author

@Anjaliavv51 can you please reveiew it and merge it

@Anjaliavv51
Copy link
Owner

Anjaliavv51 commented Oct 13, 2024 •
edited
Loading

@priyashuu
place the button , as floating one the webpage down of navbar it should be fixed.

@priyashuu
Copy link
Contributor Author

@Anjaliavv51 done with changes

@Anjaliavv51 Anjaliavv51 merged commit 75c9ac2 into Anjaliavv51:main Oct 15, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@Anjaliavv51
Copy link
Owner

@priyashuu thanks for this implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@priyashuu priyashuu

Labels
enhancement New feature or request good first issue Good for newcomers gssoc-ext hacktoberfest-accepted Level 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨[feature Request]: Add Dark Mode Toggle Button
2 participants
@priyashuu @Anjaliavv51