feat: enable react server-side rendering with image support#191
Open
azizur wants to merge 1 commit intoAnomalyInnovations:masterfrom
Open
feat: enable react server-side rendering with image support#191azizur wants to merge 1 commit intoAnomalyInnovations:masterfrom
azizur wants to merge 1 commit intoAnomalyInnovations:masterfrom
Conversation
Member
|
Thanks for the PR @azizur. Appreciate the effort.
This might be outside the scope of bundle.
Can you elaborate on this? And what else would we need to do to support React server side rendering? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR, be gentle with your review comments.
I wanted to use React component for HTML emails sent via Simple Email Service (Amazon SES). This change allows me to render React Components into static HTML as part of the email body.
More efforts are need:
This probably not an optimal solution since not all projects using
serverless-bundlewill need this capability. I would love to have this enabled via config/option inserverless.yml. Even then, I am not sure how'd avoid installing additional packages?Your feedback is really appreciated.
fixes: #136