Fix inconsistent package requirements: typescript, @typescript-eslint/eslint-plugin, @typescript-eslint/parser`#294
Open
mfogel wants to merge 2 commits intoAnomalyInnovations:masterfrom
Open
Conversation
Appears it was out of sync with package.json
For compatibility with other packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this commit to bump dependency minor versions seems to have caused two problems.
The first issue is simple: it caused
package.jsonandpackage-lock.jsonto get out-of-sync.The second issue is more complicated:
4.2.4to4.5.5@typescript-eslint/eslint-pluginand@typescript-eslint/parserare still on the4.xline, and don't support typescript4.5.X.The result is when
sls packageis run the following warning is printed to the console:To support typescript
4.5.X,@typescript-eslint/eslint-pluginand@typescript-eslint/parserwould need to be upgraded to the next major version.Until that's done, it might be a good idea to relax the version requirement on typescript to include the
4.4.Xline. That's what this PR does.This PR also updates
package-lock.jsonso it's consistent withpackage.json.