Skip to content

chore: ♻️ Updated version from 1.3.0 to 1.4.0.#1888

Merged
Anselmoo merged 2 commits into
mainfrom
release/v1.4.0
May 4, 2025
Merged

chore: ♻️ Updated version from 1.3.0 to 1.4.0.#1888
Anselmoo merged 2 commits into
mainfrom
release/v1.4.0

Conversation

@Anselmoo
Copy link
Copy Markdown
Owner

@Anselmoo Anselmoo commented May 4, 2025

  • Added from __future__ import annotations to enable postponed evaluation of type annotations.
  • Organized import statements by grouping standard library imports, third-party imports, and local application imports.
  • Removed redundant imports and ensured consistent formatting across various files in the spectrafit package.
  • Updated version in uv.lock from 1.3.0 to 1.4.0.

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Update project version and improve type annotation and import organization

New Features:

  • Added support for postponed type annotations using from __future__ import annotations

Enhancements:

  • Organized import statements across the project
  • Added Ruff configuration for import sorting

Chores:

  • Bumped project version from 1.3.0 to 1.4.0

Anselmoo added 2 commits May 4, 2025 11:21
…ity and maintainability

- Added `from __future__ import annotations` to enable postponed evaluation of type annotations.
- Organized import statements by grouping standard library imports, third-party imports, and local application imports.
- Removed redundant imports and ensured consistent formatting across various files in the `spectrafit` package.
- Updated version in `uv.lock` from 1.3.0 to 1.4.0.
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented May 4, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  spectrafit/plugins/pkl_converter.py  100% smaller
  tools/spectra_generator.py  54% smaller
  pyproject.toml Unsupported file format
  spectrafit/__init__.py  0% smaller
  spectrafit/api/cmd_model.py  0% smaller
  spectrafit/api/file_model.py  0% smaller
  spectrafit/api/models_model.py  0% smaller
  spectrafit/api/notebook_model.py  0% smaller
  spectrafit/api/pptx_model.py  0% smaller
  spectrafit/api/report_model.py  0% smaller
  spectrafit/api/rixs_model.py  0% smaller
  spectrafit/api/test/test_cmd_model.py  0% smaller
  spectrafit/api/test/test_file_model.py  0% smaller
  spectrafit/api/test/test_models_model.py  0% smaller
  spectrafit/api/test/test_notebook_model.py  0% smaller
  spectrafit/api/test/test_pptx_model.py  0% smaller
  spectrafit/api/test/test_rixs_model.py  0% smaller
  spectrafit/api/test/test_tools_model.py  0% smaller
  spectrafit/api/tools_model.py  0% smaller
  spectrafit/app/app.py  0% smaller
  spectrafit/app/test/test_app.py  0% smaller
  spectrafit/models.py  0% smaller
  spectrafit/plotting.py  0% smaller
  spectrafit/plugins/color_schemas.py  0% smaller
  spectrafit/plugins/converter.py  0% smaller
  spectrafit/plugins/data_converter.py  0% smaller
  spectrafit/plugins/file_converter.py  0% smaller
  spectrafit/plugins/notebook.py  0% smaller
  spectrafit/plugins/pkl_visualizer.py  0% smaller
  spectrafit/plugins/pptx_converter.py  0% smaller
  spectrafit/plugins/rixs_converter.py  0% smaller
  spectrafit/plugins/rixs_visualizer.py  0% smaller
  spectrafit/plugins/test/test_color_schemas.py  0% smaller
  spectrafit/plugins/test/test_converter.py  0% smaller
  spectrafit/plugins/test/test_notebook.py  0% smaller
  spectrafit/plugins/test/test_rixs_visualizer.py  0% smaller
  spectrafit/report.py  0% smaller
  spectrafit/spectrafit.py  0% smaller
  spectrafit/test/test_init.py  0% smaller
  spectrafit/test/test_input.py  0% smaller
  spectrafit/test/test_models.py  0% smaller
  spectrafit/test/test_plot.py  0% smaller
  spectrafit/test/test_report.py  0% smaller
  spectrafit/test/test_tools.py  0% smaller
  spectrafit/tools.py  0% smaller
  spectrafit/utilities/test/test_transformer.py  0% smaller
  spectrafit/utilities/transformer.py  0% smaller
  uv.lock Unsupported file format

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 4, 2025

Reviewer's Guide

This pull request bumps the project version to 1.4.0, introduces from __future__ import annotations for improved type hinting, and standardizes import organization across multiple files using Ruff/isort configured in pyproject.toml.

File-Level Changes

Change Details Files
Bumped project version to 1.4.0.
  • Updated version number in pyproject.toml.
  • Updated __version__ dunder variable.
  • Updated version assertion in tests.
pyproject.toml
spectrafit/__init__.py
spectrafit/test/test_init.py
Standardized code formatting and type annotation handling.
  • Added from __future__ import annotations for postponed evaluation.
  • Reordered import statements based on standard library, third-party, and local groupings.
  • Configured Ruff linting and isort settings in pyproject.toml.
pyproject.toml
spectrafit/plugins/pkl_converter.py
spectrafit/api/cmd_model.py
spectrafit/api/file_model.py
spectrafit/api/models_model.py
spectrafit/api/notebook_model.py
spectrafit/api/pptx_model.py
spectrafit/api/report_model.py
spectrafit/api/rixs_model.py
spectrafit/api/test/test_cmd_model.py
spectrafit/api/test/test_file_model.py
spectrafit/api/test/test_models_model.py
spectrafit/api/test/test_notebook_model.py
spectrafit/api/test/test_pptx_model.py
spectrafit/api/test/test_rixs_model.py
spectrafit/api/test/test_tools_model.py
spectrafit/api/tools_model.py
spectrafit/app/app.py
spectrafit/app/test/test_app.py
spectrafit/models.py
spectrafit/plotting.py
spectrafit/plugins/color_schemas.py
spectrafit/plugins/converter.py
spectrafit/plugins/data_converter.py
spectrafit/plugins/file_converter.py
spectrafit/plugins/notebook.py
spectrafit/plugins/pkl_visualizer.py
spectrafit/plugins/pptx_converter.py
spectrafit/plugins/rixs_converter.py
spectrafit/plugins/rixs_visualizer.py
spectrafit/plugins/test/test_color_schemas.py
spectrafit/plugins/test/test_converter.py
spectrafit/plugins/test/test_notebook.py
spectrafit/plugins/test/test_rixs_visualizer.py
spectrafit/report.py
spectrafit/spectrafit.py
spectrafit/test/test_input.py
spectrafit/test/test_models.py
spectrafit/test/test_plot.py
spectrafit/test/test_report.py
spectrafit/test/test_tools.py
spectrafit/tools.py
spectrafit/utilities/test/test_transformer.py
spectrafit/utilities/transformer.py
tools/spectra_generator.py
Updated dependency lock file.
  • Refreshed lock file to reflect the version bump to 1.4.0.
uv.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions Bot added testing Improve testing & coverage maintenance Maintenance & Security dependencies Pull requests that update a dependency file python Pull requests that update Python code release Release root labels May 4, 2025
@Anselmoo Anselmoo marked this pull request as ready for review May 4, 2025 09:46
@Anselmoo Anselmoo enabled auto-merge (squash) May 4, 2025 09:46
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2025

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

  • The pull request title focuses on the version bump, but the changes also include significant import reorganization and annotation additions across many files.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (183d521) to head (562df31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1888   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         4388      4433   +45     
=========================================
+ Hits          4388      4433   +45     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/api/cmd_model.py 100.00% <100.00%> (ø)
spectrafit/api/file_model.py 100.00% <100.00%> (ø)
spectrafit/api/models_model.py 100.00% <100.00%> (ø)
spectrafit/api/notebook_model.py 100.00% <100.00%> (ø)
spectrafit/api/pptx_model.py 100.00% <100.00%> (ø)
spectrafit/api/report_model.py 100.00% <100.00%> (ø)
spectrafit/api/rixs_model.py 100.00% <100.00%> (ø)
spectrafit/api/test/test_cmd_model.py 100.00% <100.00%> (ø)
spectrafit/api/test/test_file_model.py 100.00% <100.00%> (ø)
... and 35 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Anselmoo Anselmoo merged commit 1e5921e into main May 4, 2025
61 of 62 checks passed
@Anselmoo Anselmoo deleted the release/v1.4.0 branch May 4, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file maintenance Maintenance & Security python Pull requests that update Python code release Release root size/XL testing Improve testing & coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant