Zero and empty string treated as nullable for xml creation #709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to this issue in fasthtml: AnswerDotAI/fasthtml#567
Currently we suppress any attribute whose value is a 0 or an empty string. However there are legimitate use cases where these can these might exist.
For example
The former example I think is purely a bug caused by:
v not in (False, None, '')Python evaluates 0 == False to true so this is an edge caseMeanwhile empty strings are more debatable. Google's dom manipulation strips out the empty string leaving the value which seems to be the same as setting it to True. https://stackoverflow.com/questions/14352113/setting-an-html-option-value-to-the-empty-string
It might be fair to say that we would just expect users to pass in None if they done want that attribute showing up in the final rendering.