Add Plash header #10
Open
Add Plash header #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pydanny
force-pushed
the
add-plash-header
branch
from
64bc73c to
2585c0e
Compare
pydanny
force-pushed
the
add-plash-header
branch
from
2585c0e to
99a3d37
Compare
plash_cli/core.py
Outdated
| @@ -27,6 +27,7 @@ def get_client(cookie_file): | |||
| raise FileNotFoundError("Plash config not found. Please run plash_login and try again.") | |||
| cookies = Path(cookie_file).read_json() | |||
| client.cookies.update(cookies) | |||
| client.headers.update({'X-PLASH': True}) | |||
There was a problem hiding this comment.
LGTM. I'm just wondering if we could also set this serverside so that it's automatically caught when the cookies are read here. And if that would be better because then we set the cookies in one place instead of two. So it will be easier to reason about what the cookies are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a header so for requests to Plash we can have client-based responses. For example, a web browser request will be different than a CLI request.