Tests/thermal params #162
Tests/thermal params #162
Conversation
|
|
||
| # Test +20% capacity | ||
| marg_cluster_plus = ThermalClusterProperties( | ||
| nominal_capacity=base_capacity * MODIFICATION_RATIO, |
There was a problem hiding this comment.
Maybe it is worth to also parametrize the test with [modification_ratio, 1/modification_ratio] to reduce code length. Ah except here you also change the cost between your test, I do not know if this is necessary or not
There was a problem hiding this comment.
@tbittar : the first part of the function is to check that the conversion succeeds for the nominal value of the parameter (base_capacity). the second part of the function is a counterfactual analysis : to check that the quality of the "reproduction" would be degraded if we change the value of the studied parameter.
Hence, adding modification_ratio*base_capacity to the parametrized list would be equivalent.
| ) | ||
| assert rel_gap_base < THERMAL_TEST_REL_ACCURACY | ||
|
|
||
| for perturbation in [MODIFICATION_RATIO, 1 / MODIFICATION_RATIO]: |
There was a problem hiding this comment.
Same remark for parametrization of course, valid for all following tests
Resolves #158