Merge pull request #3 from Antonboom/feat/another-yet-self-review

self-review fixes: no panic, no extra cycles of analysis

analyzer/analyzer.go

@@ -7,7 +7,6 @@ import (
 	"strings"
 
 	"golang.org/x/tools/go/analysis"
-	"golang.org/x/tools/go/analysis/passes/inspect"
 	"golang.org/x/tools/go/ast/inspector"
 
 	"github.com/Antonboom/testifylint/internal/analysisutil"
@@ -27,10 +26,9 @@ func New() *analysis.Analyzer {
 	cfg := config.NewDefault()
 
 	analyzer := &analysis.Analyzer{
-		Name:     name,
-		Doc:      doc,
-		URL:      url,
-		Requires: []*analysis.Analyzer{inspect.Analyzer},
+		Name: name,
+		Doc:  doc,
+		URL:  url,
 		Run: func(pass *analysis.Pass) (any, error) {
 			regularCheckers, advancedCheckers, err := newCheckers(cfg)
 			if err != nil {
@@ -55,28 +53,31 @@ type testifyLint struct {
 }
 
 func (tl *testifyLint) run(pass *analysis.Pass) (any, error) {
-	insp := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
-
+	filesToAnalysis := make([]*ast.File, 0, len(pass.Files))
 	for _, f := range pass.Files {
 		if !analysisutil.IsTestFile(pass.Fset, f) {
 			continue
 		}
 		if !analysisutil.Imports(f, testify.AssertPkgPath, testify.RequirePkgPath, testify.SuitePkgPath) {
 			continue
 		}
+		filesToAnalysis = append(filesToAnalysis, f)
+	}
 
-		// Regular checkers.
-		insp.Preorder([]ast.Node{(*ast.CallExpr)(nil)}, func(node ast.Node) {
-			tl.regularCheck(pass, node.(*ast.CallExpr))
-		})
+	insp := inspector.New(filesToAnalysis)
 
-		// Advanced checkers.
-		for _, ch := range tl.advancedCheckers {
-			for _, d := range ch.Check(pass, insp) {
-				pass.Report(d)
-			}
+	// Regular checkers.
+	insp.Preorder([]ast.Node{(*ast.CallExpr)(nil)}, func(node ast.Node) {
+		tl.regularCheck(pass, node.(*ast.CallExpr))
+	})
+
+	// Advanced checkers.
+	for _, ch := range tl.advancedCheckers {
+		for _, d := range ch.Check(pass, insp) {
+			pass.Report(d)
 		}
 	}
+
 	return nil, nil
 }
 

analyzer/testdata/src/not-test-file/file_test.go

@@ -0,0 +1,14 @@
+package main
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestNotFake(t *testing.T) {
+	var predicate bool
+
+	assert.Equal(t, true, predicate)                                   // want "bool-compare: use assert\\.True"
+	assert.Equalf(t, true, predicate, "msg with args %d %s", 42, "42") // want "bool-compare: use assert\\.True"
+}

analyzer/testdata/src/not-test-file/file_test.go.golden

@@ -0,0 +1,14 @@
+package main
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestNotFake(t *testing.T) {
+	var predicate bool
+
+	assert.True(t, predicate)                                   // want "bool-compare: use assert\\.True"
+	assert.Truef(t, predicate, "msg with args %d %s", 42, "42") // want "bool-compare: use assert\\.True"
+}

internal/checkers/diagnostic.go

@@ -27,10 +27,6 @@ func newDiagnostic(
 	msg string,
 	fix *analysis.SuggestedFix,
 ) *analysis.Diagnostic {
-	if !rng.Pos().IsValid() || !rng.End().IsValid() {
-		panic("invalid report position")
-	}
-
 	d := analysis.Diagnostic{
 		Pos:      rng.Pos(),
 		End:      rng.End(),