-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: use new types from eth_pydantic_types
#2322
Draft
bitwise-constructs
wants to merge
6
commits into
ApeWorX:main
Choose a base branch
from
bitwise-constructs:feat/upgrade-pydantic-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor!: use new types from eth_pydantic_types
#2322
bitwise-constructs
wants to merge
6
commits into
ApeWorX:main
from
bitwise-constructs:feat/upgrade-pydantic-types
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pgrade-pydantic-types
…de-pydantic-types
Will have to either target feat/0-9 branch or make some of these changes work w/o needing to upgrade eth-prefix dependencies in eth-pydantic-types |
56879c7
to
3569a92
Compare
eth_pydantic_types
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
…tic-types # Conflicts: # setup.py # src/ape/types/address.py # src/ape_accounts/accounts.py # src/ape_ethereum/provider.py # src/ape_node/provider.py # src/ape_test/accounts.py # tests/functional/geth/test_provider.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Uses the new names of classes after eth_pydantic_types overhaul
fixes: #
How I did it
in coordination with: ApeWorX/eth-pydantic-types#11
How to verify it
Checklist