Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accounts.resolve_address() method for resolving input into address types #2521

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Feb 19, 2025

What I did

It is much easier to resolve ENS names from an active Ape console now:

(apedev13) ➜  ape git:(feat/resolve-account) ✗ ape console                           

In [1]: accounts.resolve("vitalik.eth")
Out[1]: '0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045'

How I did it

How to verify it

Checklist

  • All changes are completed
  • Change is covered in tests
  • Documentation is complete

@antazoey antazoey changed the title feat: account address resolve method feat: accounts.resolve() method for resolving input into address types Feb 19, 2025
@antazoey antazoey requested a review from fubuloubu February 19, 2025 16:57
@antazoey antazoey force-pushed the feat/resolve-account branch 3 times, most recently from 22fb9ec to 5e8414a Compare February 19, 2025 17:22
@antazoey antazoey force-pushed the feat/resolve-account branch from 5e8414a to f8303fe Compare February 19, 2025 17:23
@antazoey antazoey changed the title feat: accounts.resolve() method for resolving input into address types feat: accounts.resolve_address() method for resolving input into address types Feb 19, 2025
fubuloubu
fubuloubu previously approved these changes Feb 19, 2025
@antazoey antazoey enabled auto-merge (squash) February 19, 2025 17:51
@antazoey antazoey merged commit 32623e3 into ApeWorX:main Feb 19, 2025
18 checks passed
@antazoey antazoey deleted the feat/resolve-account branch February 19, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants