fix: show first 4 bytes of transaction data in signing string (instead of 3) #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
antazoey
changed the title
bitwise-constructs
approved these changes
Feb 19, 2025
fubuloubu
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
should we make this configurable? like displaying the full data vs. only displaying partial?
accounts:
show_full_calldata: true # defaults `false`There was a problem hiding this comment.
I am always done for using config to change behavior like that
There was a problem hiding this comment.
ill make another PR for this feature
|
Question: what about also showing the actual method name? We should know it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Transaction showed data like (3 bytes)
but is now (4 bytes):
fixes: #2519
How I did it
How to verify it
Checklist