Fix Line Breaks and HTML Escaping #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the display-line-break.js and line-break-to-tag.js as we can rely on CSS to preserve whitespace handling.
In many cases we can use HTMLBars triple brace {{{...}}} to render content as-is. Modern browsers support not executing <script> tags. Reference: https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML . BUT this is breakable with content like:
<iframe src=""srcdoc="<script>alert('hi');</script>"></iframe>
Currently, some user input-able content is stored as plain text on the backend. Other times, it's converted to simple HTML on the front-end and saved in the backend.
This means a bunch of the {{{...}}} in this PR may not be able to be trusted. Need to circle back with team and find a uniform way of handling user inputtable content.
5 tasks
rizwanreza
added a commit
that referenced
this pull request
Sep 16, 2015
Fix Line Breaks and HTML Escaping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Please read.
Whenever we have input that's not
contenteditable, we should use double braces ({{ }}) with.preserve-line-breaksclass.When using
contenteditableinput, feel free to use triple braces ({{{ }}}). The browsers that support contenteditable boxes already escape any HTML that's injected by the user.