Skip to content

Conversation

@ofedoren
Copy link
Collaborator

@ofedoren ofedoren commented Dec 5, 2024

WDYT @ekohl and @adamruzicka ? I'd like to drop ancient relics, since the only usage of this lib known to me/rubygems is hammer-cli, which already requires Ruby 2.7 at least.

@ofedoren
Copy link
Collaborator Author

ofedoren commented Dec 9, 2024

Thanks, @ekohl ! I've dropped rest-client complexity and using shared workflow now. Not sure why it didn't trigger unlike the previous one...

@ofedoren
Copy link
Collaborator Author

ofedoren commented Dec 9, 2024

Thanks, @ekohl, this indeed makes more sense, updated.

@ekohl
Copy link
Member

ekohl commented Dec 9, 2024

GitHub doesn't trigger unknown actions. What I usually do is configure it to run on push as well (also has the benefit that it can cache gemsets between runs on different PR authors) and then push the branch temporarily to upstream. Once CI runs, I delete the branch again. I think actions are recognized by name.

@ofedoren ofedoren force-pushed the update-deps branch 3 times, most recently from a77c556 to a154bc4 Compare December 10, 2024 12:12
@ofedoren
Copy link
Collaborator Author

Thanks, @ekohl ! Seems green, worse case: we'll catch issues in hammer.

@ofedoren ofedoren merged commit 6ba6cdf into Apipie:master Dec 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants