Fix Rails 8.1 router keyword args deprecation warning #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@copilot can you check whats wrong with Rubocop ? |
mathieujobin
reviewed
Nov 7, 2025
| get(options.reverse_merge("(:version)/(:resource)/(:method)" => "apipies#index", :as => :apipie)) | ||
| get_args = options.reverse_merge("(:version)/(:resource)/(:method)" => "apipies#index", :as => :apipie) | ||
|
|
||
| Rails.version >= "5.2" ? get(**get_args) : get(get_args) |
Collaborator
There was a problem hiding this comment.
lets remove support for Rails 5.x and 6.x @copilot
and update CHANGELOG and bump the next minor version
Collaborator
|
Thanks for working on this @jamesds |
Contributor
Author
|
Thank you @mathieujobin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 8.1 is raising a deprecation warning on a single line in lib/apipie/routing.rb, where
get(and all other router methods) will be expected to use keyword arguments from Rails 8.2 onwards.The initial fix failed in the CI tests for the oldest 2 ruby/rails versions, so I've amended the fix to only apply to Rails 5.2 and above, if the older versions still need to be supported.