Skip to content

Add WebShard Editor - #3896

Open
madtunebk wants to merge 2 commits into
AppImage:masterfrom
madtunebk:add-webshard-editor
Open

madtunebk wants to merge 2 commits into
AppImage:masterfrom
madtunebk:add-webshard-editor

Conversation

@madtunebk

Copy link
Copy Markdown

Summary

Checklist

  • Desktop file passes desktop-file-validate
  • AppStream metainfo passes appstreamcli validation
  • Downloadable via plain wget/curl, no authentication
  • Attached to a GitHub Release

Copilot AI lite review requested due to automatic review settings September 14, 2026 12:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is minimal and correctly adds a new catalog entry; the only feedback is a non-blocking best-practice suggestion about using a stable “latest” download URL.

Pull request overview

Adds WebShard Editor to the appimage.github.io catalog by introducing a new data/ entry pointing to the project’s AppImage release download, enabling the CI ingestion pipeline to fetch and index it.

Changes:

  • Added a new data/webshard_editor entry containing the AppImage download URL.
File summaries
File Description
data/webshard_editor Adds the AppImage download source for WebShard Editor so it can be discovered and processed by the catalog pipeline.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread data/webshard_editor Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@madtunebk

Copy link
Copy Markdown
Author

Re-triggering CI: the underlying AppImage had a bug (winit's X11 keyboard support is dlopen'd at runtime and wasn't bundled/discoverable, causing a crash on launch). Fixed and re-uploaded to the same release asset URL.

@madtunebk madtunebk closed this Sep 14, 2026
@madtunebk madtunebk reopened this Sep 14, 2026
@madtunebk

Copy link
Copy Markdown
Author

Second fix: winit also dlopens core X11 client libs (libX11, libX11-xcb, libXcursor, libXi) at runtime, not just xkbcommon-x11 — the CI runner has none of them since it's not a desktop image. Bundled the full closure into the AppImage and re-uploaded.

@madtunebk madtunebk closed this Sep 14, 2026
@madtunebk madtunebk reopened this Sep 14, 2026
@madtunebk

Copy link
Copy Markdown
Author

Third fix: the bundled X11 libs were themselves copied from an Ubuntu 24.04 host (glibc 2.39) and required GLIBC_2.38, incompatible with the CI runner's Ubuntu 22.04 (glibc 2.35) -- same class of issue as the earlier GLIBC_2.39 binary problem, just for the bundled shared libs this time. Re-extracted them from an ubuntu:22.04 container instead (max GLIBC_2.34 now) and re-uploaded.

@madtunebk madtunebk closed this Sep 14, 2026
@madtunebk madtunebk reopened this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants