Add HyprMX 6.4.3.0 #832
Add HyprMX 6.4.3.0 #832
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
|
Needs dependency bump to use 6.4.3 version of HyprMX android. |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Unspecified Coroutines Version ▹ view | |
 |
Inconsistent plugin application pattern ▹ view | |
 |
Overly Complex Boolean Logic ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| HyprMX/build.gradle.kts | ✅ |
| HyprMX/src/main/java/com/applovin/mediation/adapters/HyprMXMediationAdapter.java | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| val libraryVersionName by extra("6.4.3.0") | ||
|
|
||
| dependencies { | ||
| implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:+") |
There was a problem hiding this comment.
Unspecified Coroutines Version 
Tell me more
What is the issue?
Using the '+' version notation for dependencies can lead to unpredictable builds and runtime behavior
Why this matters
Each build might pull a different version of coroutines, potentially introducing incompatibilities or bugs in production that weren't present during testing
Suggested change ∙ Feature Preview
Specify a fixed version for the coroutines dependency. For example:
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3")Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.
| plugins { | ||
| id("adapter-config") | ||
| } | ||
|
|
||
| afterEvaluate { | ||
| apply(plugin = "adapter-publish") | ||
| } |
There was a problem hiding this comment.
Inconsistent plugin application pattern 
Tell me more
What is the issue?
The design splits plugin application across two different methods (plugins block and afterEvaluate), making the build configuration harder to understand and maintain.
Why this matters
This structure creates unnecessary complexity and makes it harder to reason about when plugins are applied. The afterEvaluate block should be avoided when possible as it makes the build script's execution order less predictable.
Suggested change ∙ Feature Preview
Consolidate plugin declarations in the plugins block when possible:
plugins {
id("adapter-config")
id("adapter-publish")
}Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.
| if ( ( isNull( isDoNotSell ) || isFalse( isDoNotSell ) ) && isTrue( hasUserConsent ) ) | ||
| { | ||
| return ConsentStatus.CONSENT_GIVEN; | ||
| } | ||
| else if ( isTrue( isDoNotSell ) || isFalse( hasUserConsent ) ) | ||
| { | ||
| return ConsentStatus.CONSENT_DECLINED; | ||
| } | ||
| else | ||
| { | ||
| return ConsentStatus.CONSENT_STATUS_UNKNOWN; | ||
| } |
There was a problem hiding this comment.
Overly Complex Boolean Logic 
Tell me more
What is the issue?
The consent status logic uses helper methods isTrue/isFalse/isNull which make the boolean logic harder to follow than necessary.
Why this matters
Complex boolean expressions become more difficult to understand when wrapped in helper methods. This increases cognitive load when trying to understand the business logic.
Suggested change ∙ Feature Preview
if (hasUserConsent != null && hasUserConsent && (isDoNotSell == null || !isDoNotSell)) {
return ConsentStatus.CONSENT_GIVEN;
} else if ((isDoNotSell != null && isDoNotSell) || (hasUserConsent != null && !hasUserConsent)) {
return ConsentStatus.CONSENT_DECLINED;
} else {
return ConsentStatus.CONSENT_STATUS_UNKNOWN;
}Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.
|
Hi team, could you share an estimate for when HyprMX 6.4.3 will be integrated and released in the MAX adapter? We need the 16KB page size support for Android 15. Thanks. |
3 participants
Description by Korbit AI
What change is being made?
Add the
HyprMXSDK integration by creating a new directory with essential files for the adapter setup, including implementation details for banner, interstitial, and rewarded ad formats.Why are these changes being made?
The integration of HyprMX SDK aims to extend the ad mediation capabilities of the application by providing additional ad-serving infrastructure. This addition allows the application to support a variety of ad formats and improve monetization strategies through better ad fill rates and enhanced targeting offered by HyprMX.