Skip to content

feat: create pixel#221

Merged
MessiasLima merged 3 commits into
mainfrom
184-feature-implement-missing-pixel-endpoint
Jun 25, 2026
Merged

feat: create pixel#221
MessiasLima merged 3 commits into
mainfrom
184-feature-implement-missing-pixel-endpoint

Conversation

@MessiasLima

Copy link
Copy Markdown
Member

No description provided.

@MessiasLima MessiasLima linked an issue Jun 25, 2026 that may be closed by this pull request
2 tasks
@MessiasLima MessiasLima changed the title 184 feature implement missing pixel endpoint feat: Create pixel Jun 25, 2026
@MessiasLima MessiasLima changed the title feat: Create pixel feat: create pixel Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the tracking pixel creation endpoint (createPixel) along with its documentation and tests. It also introduces reusable test fixtures for Pixel, Team, TeamMember, and User models to replace inline object literals in tests, aligning with the project's testing guidelines. The review feedback suggests several improvements to these fixtures, such as defaulting deletedAt to null to represent active entities by default, and dynamically linking IDs between parent and nested fixtures (e.g., matching teamId and userId in Team and TeamMember fixtures) to ensure data consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@MessiasLima MessiasLima merged commit 01e0a06 into main Jun 25, 2026
1 of 2 checks passed
@MessiasLima MessiasLima deleted the 184-feature-implement-missing-pixel-endpoint branch June 25, 2026 18:02
@github-project-automation github-project-automation Bot moved this from To Do to Done in Umami Kotlin Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feature: Implement missing Pixel endpoint

1 participant