Skip to content

chore: bootstrap kombu#223

Merged
MessiasLima merged 8 commits into
mainfrom
197-create-samplekombu-gradle-module-with-all-kmp-targets-per-platform-windowing-and-umami-api-dependency
Jun 27, 2026
Merged

chore: bootstrap kombu#223
MessiasLima merged 8 commits into
mainfrom
197-create-samplekombu-gradle-module-with-all-kmp-targets-per-platform-windowing-and-umami-api-dependency

Conversation

@MessiasLima

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the old sample application with a new Kotlin Multiplatform sample named 'kombu', which supports Android, Desktop, iOS, and Web (JS/Wasm) targets. It also updates Gradle, AGP, and various dependencies, and refactors build configurations across the project. Feedback on the changes includes addressing a potential compilation issue in Platform.js.kt due to incorrect Pair destructuring in a lambda, and removing a redundant dependency declaration for Compose UI Tooling Preview in the shared module's androidMain source set.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sample/kombu/shared/build.gradle.kts
@MessiasLima MessiasLima changed the title 197 create samplekombu gradle module with all kmp targets per platform windowing and umami api dependency chore: kombu boostratp Jun 27, 2026
@MessiasLima MessiasLima changed the title chore: kombu boostratp chore: kombu boostrap Jun 27, 2026
@MessiasLima MessiasLima changed the title chore: kombu boostrap chore: bootstrap kombu Jun 27, 2026
@MessiasLima MessiasLima merged commit c5c7ad7 into main Jun 27, 2026
2 checks passed
@MessiasLima MessiasLima deleted the 197-create-samplekombu-gradle-module-with-all-kmp-targets-per-platform-windowing-and-umami-api-dependency branch June 27, 2026 23:37
@github-project-automation github-project-automation Bot moved this from To Do to Done in Umami Kotlin Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Create :sample:kombu Gradle module with all KMP targets, per-platform windowing, and :umami-api dependency

1 participant