After requesting not granted permissions, the result should be dispatched on main thread#451
Open
korzonkiee wants to merge 1 commit intoApparence-io:masterfrom
Open
After requesting not granted permissions, the result should be dispatched on main thread#451korzonkiee wants to merge 1 commit intoApparence-io:masterfrom
korzonkiee wants to merge 1 commit intoApparence-io:masterfrom
Conversation
…ispatched on main thread
|
This solution didn't work for me. It wasn't just the sentry logs that were crashing; the app was actively crashing. I have posted a fix on #511. |
684b840 to
0b8430c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Seeing the following crash reported multiple times in Sentry:
After some investigation, it turned out that after requesting the not-granted permissions, the callback function is invoked from the
IOthread, which then leads to thejava.lang.RuntimeException: Methods marked with @UiThread must be executed on the main thread. In order to fix it, we must dispatch thecallbackinvocation to the main thread, similarily as in the case of requesting audio permission.Closes #450
Checklist
Before creating any Pull Request, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).flutter analyzewithout any issues.Breaking Change
If your feature break something, please detail it