Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makerobin.cpp #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RcktMan77
Copy link

Perhaps I'm wrong, but shouldn't the chebynev node affine transformation be: 0.5 * (a+b) + 0.5*(b-a)cos( (2k - 1)pi/(2n) ), for k = 1, 2, 3..., n ?

Perhaps I'm wrong, but shouldn't the chebynev node affine transformation be: 0.5 * (a+b) + 0.5*(b-a)*cos( (2*k - 1)*pi/(2*n) ), for k = 1, 2, 3..., n ?
@markstock
Copy link
Collaborator

We iterate our k from [0..n] inclusive, so the formula works.

Also - I'm glad you're interested in using our code! Did you try to search the net for the geometry, or try to code it from the original papers?

@RcktMan77
Copy link
Author

RcktMan77 commented Jun 1, 2021 via email

@markstock
Copy link
Collaborator

We went through the same frustrating process that you did. Apparently most researchers forgot how they made the geometry or had someone else do it. That's why we thought it was important to fix the coefficients and publish a repository and tech report (soon to be published).
We found the new coefficients by looking at the several publications that offered them, and by simply fixing the ones that always broke in our own program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants