Skip to content

Replace pyreadr#57

Merged
jakubnowicki merged 6 commits intodevelopfrom
replace-pyreadr
Feb 27, 2026
Merged

Replace pyreadr#57
jakubnowicki merged 6 commits intodevelopfrom
replace-pyreadr

Conversation

@jakubnowicki
Copy link
Member

Have you read the Contributing Guidelines?

Issue #

Description

Clear and concise description of what changed and why.
If necessary, include screenshots and/or a step-by-step guide on how to test the changes.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces pyreadr with rdata for reading .rds files, and aligns the project/tooling with a Python 3.11+ baseline.

Changes:

  • Swap the RDS reader implementation from pyreadr to rdata, adding custom constructors for Date and POSIXct (with NaN-aware conversions).
  • Add unit tests covering the new constructors and datetime type inference behavior.
  • Bump minimum supported Python to 3.11 and update CI matrix/versioning accordingly.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tealflow_mcp/utils/dataset_readers.py Re-implements RDS loading via rdata, adds Date/POSIXct constructors and datetime type inference.
tests/test_dataset_readers.py Adds tests for NaN-safe constructors and _infer_datetime_type.
pyproject.toml Replaces pyreadr with rdata, bumps Python requirement to >=3.11, updates tooling targets.
.github/workflows/ci.yml Updates CI Python versions to 3.11–3.13 and adjusts coverage run version.
tealflow_mcp/__init__.py Version bump to 0.2.0.dev2.
uv.lock Lockfile refresh reflecting dependency switch and Python version bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jakubnowicki jakubnowicki merged commit 4827af6 into develop Feb 27, 2026
6 checks passed
@jakubnowicki jakubnowicki deleted the replace-pyreadr branch February 27, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants