Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: security feature - login history #560

Open
wants to merge 5 commits into
base: POLARDB_15_STABLE
Choose a base branch
from

Conversation

manfuldrifter
Copy link

Show the user the last login information.

Show the user the last login information.
@CLAassistant
Copy link

CLAassistant commented Feb 26, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ manfuldrifter
❌ yangsn6
You have signed the CLA already but the status is still pending? Let us recheck it.

@polardb-bot
Copy link

polardb-bot bot commented Feb 26, 2025

Hi @manfuldrifter ~ Congratulations to your first PR to PolarDB. 🎉

Please make sure that your PR conforms the standard, and has passed all the checks.

We will review your PR as soon as possible.

@polardb-bot
Copy link

polardb-bot bot commented Feb 26, 2025

Hey @manfuldrifter :

Something wrong occuried during the checks of your commit 😟, please check the detail:

⚠️ stylecheck (anolis8) View more details

@polardb-bot polardb-bot bot added the ci/failure CI status is failure label Feb 26, 2025
Show the user the last login information.
Show the user the last login information.
@polardb-bot
Copy link

polardb-bot bot commented Feb 26, 2025

Hey @manfuldrifter :

Something wrong occuried during the checks of your commit 😟, please check the detail:

⚠️ stylecheck (anolis8) View more details

@polardb-bot polardb-bot bot added ci/failure CI status is failure and removed ci/failure CI status is failure labels Feb 26, 2025
@polardb-bot
Copy link

polardb-bot bot commented Feb 26, 2025

Hey @manfuldrifter :

Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review.

@polardb-bot polardb-bot bot added ci/success CI status is success and removed ci/failure CI status is failure labels Feb 26, 2025
@yangsn6
Copy link

yangsn6 commented Mar 1, 2025

Hello, I want to write history login information asynchronously through a process, which existing process is better to use? Or a new process?

1.Use partition locks for the hash table
2.Delete the login information when the transaction is committed
@polardb-bot
Copy link

polardb-bot bot commented Mar 17, 2025

Hey @manfuldrifter :

Something wrong occuried during the checks of your commit 😟, please check the detail:

⚠️ regression (rocky9, precheck-main, off) View more details

@polardb-bot polardb-bot bot added ci/failure CI status is failure and removed ci/success CI status is success labels Mar 17, 2025
@polardb-bot
Copy link

polardb-bot bot commented Mar 18, 2025

Hey @manfuldrifter :

Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review.

@polardb-bot polardb-bot bot added ci/success CI status is success and removed ci/failure CI status is failure labels Mar 18, 2025
endif

check:
$(prove_check)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to have an empty line at the end of each file.

comment = 'record user login information'
default_version = '1.0'
module_pathname = '$libdir/polar_login_history'
relocatable = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for an empty line.

use PostgreSQL::Test::Utils;
use Test::More;

my $node = PostgreSQL::Test::Cluster->new('primary');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test case covers replica node?

Adjust the format and add the test case
@polardb-bot
Copy link

polardb-bot bot commented Mar 20, 2025

Hey @manfuldrifter :

Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review.

@polardb-bot polardb-bot bot added ci/success CI status is success and removed ci/success CI status is success labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/success CI status is success
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants