-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: security feature - login history #560
base: POLARDB_15_STABLE
Are you sure you want to change the base?
feat: security feature - login history #560
Conversation
Show the user the last login information.
|
Hi @manfuldrifter ~ Congratulations to your first PR to PolarDB. 🎉 Please make sure that your PR conforms the standard, and has passed all the checks. We will review your PR as soon as possible. |
Hey @manfuldrifter : Something wrong occuried during the checks of your commit 😟, please check the detail:
|
Show the user the last login information.
Show the user the last login information.
Hey @manfuldrifter : Something wrong occuried during the checks of your commit 😟, please check the detail:
|
Hey @manfuldrifter : Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review. |
Hello, I want to write history login information asynchronously through a process, which existing process is better to use? Or a new process? |
1.Use partition locks for the hash table 2.Delete the login information when the transaction is committed
Hey @manfuldrifter : Something wrong occuried during the checks of your commit 😟, please check the detail:
|
Hey @manfuldrifter : Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review. |
endif | ||
|
||
check: | ||
$(prove_check) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to have an empty line at the end of each file.
comment = 'record user login information' | ||
default_version = '1.0' | ||
module_pathname = '$libdir/polar_login_history' | ||
relocatable = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for an empty line.
use PostgreSQL::Test::Utils; | ||
use Test::More; | ||
|
||
my $node = PostgreSQL::Test::Cluster->new('primary'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this test case covers replica node?
Adjust the format and add the test case
Hey @manfuldrifter : Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review. |
Show the user the last login information.