Fix XmLog segfault in pybind11 shared libraries#112
Merged
Conversation
std::ofstream locale facets (codecvt vtable) are NULL when the .so is statically linked against libstdc++ and loaded into a Python process. Replace std::ofstream with FILE*/fprintf and std::put_time with std::strftime so the log writer no longer depends on locale machinery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::ofstreamwithFILE*/fprintfinXmLogto avoid segfaults caused by NULL locale facets (codecvt vtable) when the.sois statically linked against libstdc++ and loaded into a Python processstd::put_timewithstd::strftimeand theoperator<<overload with a plainiSeverityStr()function to eliminate all remaining iostream/locale dependencies in the log writerTest plan
runner)import xmscoreno longer segfaults in Python