Fix Glass Sacrificial Dagger bypassing death events#177
Open
lL1l1 wants to merge 2 commits into
Open
Conversation
Used 1.12 Blood Magic's sacrificial dagger as reference: https://github.com/WayofTime/BloodMagic/blob/1.12/src/main/java/WayofTime/bloodmagic/item/ItemSacrificialDagger.java#L96-L107 WayofTime/BloodMagic@572d8ef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used 1.12 Blood Magic's Sacrifical Dagger as reference:
"Possible fix to (many of the) abnormal death events concerning the sacrificial Dagger (#1554)"
Tested with draconic evolution draconic armor, astral sorcery phoenix blessing, avaritia infinity armor, blood magic's living armor's grim reaper's sprint upgrade, and corail tombstone. All latest versions of the mods on 1.12.
Test results: Draconic armor now dies like it does with the blood magic dagger. Phoenix blessing, grim reaper's sprint, and infinity armor revive you instead of dying and leaving no grave behind.
This fixes graves being lost when dying to the glass sacrificial dagger while having revive abilities.