CCCharles: Add a missed item to the pool + locations/regions renaming #5711
+774
−759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> The logic has been tested, the game can be completed > The logic is simple and it does not take into account options ! The documentations are a work in progress
> Redacted French and English Setup Guides > Redacted French and English Game Pages
> Revert unexpected changes on .run\Archipelago Unittests.run.xml (base Archipelago file) > Fixed typo "querty" -> "qwerty" in fr and eng Game Pages > Adding "Game page in other languages" section to eng Game Page documentation > Improved Steam path in fr and eng Setup Guides
> Added get_filler_item_name() to remove warnings > Fixed irrelevant links for documentations > Used the Player Options page instead of the default YAML on GitHub > Reworded all locations to make them simple and clear > Split some locations that can be linked with an entrance rule > Reworked all options > Updated regions according to locations > Replaced unnecessary rules by rules on entrances
Only the base options are handled yet, "work in progress" features removed.
> Fixed specific UT name
> UT updated by replacing depreciated features
This start_inventory_from_pool option is like regular start inventory but it takes items from the pool and replaces them with fillers Co-authored-by: Scipio Wright <[email protected]>
> Mainly fixed editorial and minor issues without impact on UT results (still passed)
> Updated the depreciated guides because the may to release the Mod has been changed > Removed the fixed issues from 'Known Issues' > Add the "Mod Download" section to simplify the others sections.
> base_id reduced to ensure it fits to signed int (32 bits) in case of future AP improvements
> Set topology_present to False because unnecessary > Added an exception in case of unknown item instead of using filler classification > Fixed an issue that caused the "Bug Spray" to be considered as filler > Reworked the test_claire_breakers() test to ensure the lighthouse mission can only be finished if at least 4 breakers are collected
> The victory could be accessed from sphere 1, this is now fixed by adding the following items as requirements: - Temple Key - Green Egg - Blue Egg - Red Egg
> "North Mine Outside Scraps 15" added, IDs shifted accordingly > Replaced old comments "KO" by "\!/ Existing match [...]"
> Locations have a dash '-' when a description is required to differentiate items > Locations now have better descriptions > Some Regions are slightly renamed to be shorter
github-actions
bot
added
the
waiting-on: peer-review
duckboycool
approved these changes
Dec 11, 2025
Contributor
duckboycool
left a comment
duckboycool
left a comment
There was a problem hiding this comment.
Just changing names and IDs basically, and the changes seem fine. Also tried test genning locally.
Contributor
|
New changes also seem fine as far as the world side goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
How was this tested?
By running all the Unit Tests to check no logic is broken, all passed.
If this makes graphical changes, please attach screenshots.
No graphical changes.