Core: Make .apworlds importable using importlib (without force-importing them first) #5734
+22
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
NewSoupVi
added
the
is: enhancement
NewSoupVi
changed the title
NewSoupVi
changed the title
NewSoupVi
changed the title
NewSoupVi
changed the title
Berserker66
approved these changes
Dec 11, 2025
Member
Berserker66
left a comment
Berserker66
left a comment
There was a problem hiding this comment.
It looks correct. I think we should merge this early next release cycle and then see if there's any problems arising from this change during it.
Member
Author
|
Sure. I've also been trying to think about how to make a unittest for this... Basically APWorld Builder -> Delete corresponding world folders -> Generate a MW per game (on a new process) or maybe something less "destructive" than that lol but something along those lines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that
import worlds.apquestworks without any of the module manipulation, which simplifies & unifies theWorldSource.load_world()codepath, and crucially will bring us one step closer to lazy loading.I'm not sure it's okay that I'm just ignoring
pathandtarget. I will have to look into it more.Tested:
Removed worlds/apquest/, added worlds/apquest.apworld, launched APQuest client successfully.