Write itemclassification for precollected items into the multidata #5744
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Contributor
Author
|
@beauxq You added typing to Multidata and I just changed it. If you don't mind could you let me know if I did it in way you would approve of? Thanks. |
…e to make a commit and find out if it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Previously, all precollected items were 'filler' according to the server. Now the classifications are written into the multidata so the server can report them accurately
How was this tested?
I generated before I made any changes, then I did a generation after the changes.
I uploaded both pre- and post- change generations to a local webhost in order to ensure compatibility.
Then I connected to the rooms and did a /received
If this makes graphical changes, please attach screenshots.
Post-change
Pre-change
