Switch CAN port definiton on Nucleo-496 hwdef #23070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CAN port as it was is a valid CAN port for the nucleo, but on the development board the CAN silkscreen is actually on PD0 and PD1. This change makes it easier to get the example running on the Nucleo
RobertatPegasus
force-pushed
the
fix-nucleo-L496
branch
from
a247844 to
9bbfcb7
Compare
|
Thanks for this. I've fixed up the commit list and commit messages to conform to our standards and created a new PR here: #28229 (I was unable to force-push your branch here). I've marked that new PR as MergeOnCIPass. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CAN port as it was is a valid CAN port for the Nucleo, but on the development board the CAN silkscreen is actually on PD0 and PD1. This change makes it easier to get the example running on the Nucleo.
This was tested on a real Nucleo board. The CAN tx/rx was plugged in to a tranceiver which was plugged in to a pixhawk 4. I installed the bootloader first on the nucleo with an st-link, then updated the firmware image with mission planner. The Nucleo was active on the CAN bus in both images.