Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NaN in camera fields when no value known #28212

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

peterbarker
Copy link
Contributor

per-spec

Replaces https://github.com/ArduPilot/ardupilot/pull/25010/files

Creates a global NaNf per @rmackay9 's suggestion

@rmackay9
Copy link
Contributor

Great to see the arrival of NANf!

@peterbarker peterbarker changed the title Use NaN is camera fields when no value known Use NaN in camera fields when no value known Sep 24, 2024
@peterbarker
Copy link
Contributor Author

There's no compiler output change right up until the changes to the mavlink packets in this PR. Using NanF in those packets costs 16 bytes on some platforms.

@peterbarker
Copy link
Contributor Author

I've used SITL to test the base backend, but no simulators for any of three more-specific backends

libraries/AP_Mount/AP_Mount_Topotek.cpp Outdated Show resolved Hide resolved
libraries/AP_Mount/AP_Mount_Viewpro.cpp Outdated Show resolved Hide resolved
libraries/AP_Mount/AP_Mount_Xacti.cpp Outdated Show resolved Hide resolved
libraries/AP_Mount/AP_Mount_Xacti.cpp Outdated Show resolved Hide resolved
libraries/AP_Camera/AP_Camera_Backend.cpp Outdated Show resolved Hide resolved
libraries/AP_Camera/AP_Camera_Backend.cpp Outdated Show resolved Hide resolved
libraries/AP_Mount/AP_Mount_Siyi.cpp Outdated Show resolved Hide resolved
@peterbarker peterbarker merged commit decf484 into ArduPilot:master Sep 26, 2024
95 checks passed
@peterbarker peterbarker deleted the pr/global-nan branch September 26, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants