Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_KDECAN: standardize on 32 bit microsecond CAN timeouts #28360

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

tpwrules
Copy link
Contributor

@tpwrules tpwrules commented Oct 9, 2024

For consistency with other parts of the code.

Turns out there is no compiler output change (unless I change a timeout value); the compiler already does this optimization. But I already wrote the code and spent the CPU to test it... The eventual goal is to make CANSensor::write_frame take a 32 bit value.

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *                                       

For consistency with other parts of the code. No compiler output change.
@peterbarker
Copy link
Contributor

Can be merged once surprising binary-identical-output is confirmed

@peterbarker peterbarker merged commit 9a497fe into ArduPilot:master Oct 10, 2024
98 checks passed
@tpwrules tpwrules deleted the pr/kdecan-timeout-us branch October 26, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants