-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename SRV_Channel::Aux_servo_function_t to SRV_Channel::Function #29085
Rename SRV_Channel::Aux_servo_function_t to SRV_Channel::Function #29085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As always there are some concerns about difficulties doing backports once this is merged but in that case we could consider backporting this as well I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, maybe we can remove the k_
on all the functions in the future too.
I did play around with making this actually an enum-class, rather than just looking like one. It involves inserting |
92f495d
to
1221a33
Compare
1221a33
to
310faf6
Compare
happy with the rename, no enum class change in this PR please |
310faf6
to
0cf4dee
Compare
I've rebased to resolve conflicts. Still no compiler output change |
0cf4dee
to
d771e76
Compare
Not only is the new name shorter, it's also more in-keeping with the way we do enum-class names elsewhere in the code.
Additionally, the word "aux" in the old name is completely misleading - this covers all servo functions, not just "auxiliary" functions!
This is a no-compiler-output-change PR: