AP_HAL_ChibiOS: chibios_hwdef.py tidy embedding of files into ROMFS #29161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I certainty tested this when I did #26157, it worked then. Could the difference be using |
peterbarker
force-pushed
the
pr/embed-directories-lua
branch
from
3483d50 to
46e957f
Compare
They're completely different paths, both walking the tree. OTOH, it turns out this "fix" isn't required at all. No idea what went wrong to make me think it was required. Changed this to just neaten the function up, rather than modifying its functionality |
peterbarker
force-pushed
the
pr/embed-directories-lua
branch
from
46e957f to
3c0e614
Compare
peterbarker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most notably this embed the "modules" directory so you can use modules in ROMFS
I've created a branch which shows this working here: https://github.com/ArduPilot/ardupilot/compare/master...peterbarker:ardupilot:DEBUG/demo-pr/modules-in-romfs?expand=1 . It creates an OEM board which embeds a script and a library for it to use. Note that there are several drive-by patches in that branch at this point.