Tools: uploader.py: verify correct install #29164
Open
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafasaurus
commented
Jan 28, 2025
rafasaurus
commented
- Implement functionality to verify correct firmware installation
- Utilize existing code with an additional argument for verification
- Implement functionality to verify correct firmware installation - Utilize existing code with an additional argument for verification
shifter97
approved these changes
Jan 28, 2025
peterbarker
requested changes
Jan 28, 2025
There was a problem hiding this comment.
"verify" is really, "verify that the flash worked".
You're re-using the functionality, but that terminology isn't really applicable in this case.
I'm OK with the current name of the parameter, but if we can find something better that would be good!
--assert-firmware-is would work, but a little verbose
In any case, a slightly better description is called for...
peterbarker
requested changes
Jan 28, 2025
Better argument description Co-authored-by: Peter Barker <[email protected]>
Should we just squash and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.