Add AP_AirSensor library #29219
Draft
Add AP_AirSensor library #29219
+782
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
* Scripting bindings don't seem to show up yet Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
peterbarker
requested changes
Feb 4, 2025
| enum class Type { | ||
| NONE, | ||
| #if AP_AIRSENSOR_SCRIPTING_ENABLED | ||
| SCRIPTING |
There was a problem hiding this comment.
Suggested change
| SCRIPTING | |
| SCRIPTING, |
| _backend_type = (AP_AirSensor::Type )_params.type.get(); | ||
| } | ||
|
|
||
| bool AP_AirSensor_Backend::get_aoa(float& a) const { |
There was a problem hiding this comment.
Let's be consistent about where that opening brace is!
ArduPilot convention is on a fresh line, but we differ across libraries
There was a problem hiding this comment.
I'll run astyle on all this before it's actually put up for review. I'm more concerned with architecture than code style at this moment.
Comment on lines
+26
to
+34
| virtual bool init() = 0; | ||
| virtual ~AP_AirSensor_Backend() {} | ||
| virtual void update() = 0; | ||
| // get measured wind vector [m/s] | ||
| virtual bool get_wind(Vector3f& wind_uvw) const { return false; } | ||
| // get measured angle of attack [rad] | ||
| virtual bool get_aoa(float& a) const; | ||
|
|
||
| #if AP_SCRIPTING_ENABLED |
There was a problem hiding this comment.
certical whitespace here somewhere, please!
| #endif | ||
|
|
||
| #ifndef AP_AIRSENSOR_SCRIPTING_ENABLED | ||
| #define AP_AIRSENSOR_SCRIPTING_ENABLED (AP_AIRSENSOR_ENABLED && AP_SCRIPTING_ENABLED) |
There was a problem hiding this comment.
create an AP_AIRSENSOR_BACKEND_DEFAULT_ENABLED
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for initial feedback- see the README.
A bit of an alternative to #29107 that leaves AP_Airspeed as is