Feature/professionalize app #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a series of changes to improve the overall quality, maintainability, and visual consistency of the Flutter weather application, aligning it with more professional standards and preparing it for an upgrade to Flutter 3.16+ (Dart 3+).
Key changes include:
1. **SDK Constraint & Linting:**
* Updated `pubspec.yaml` to target Flutter SDK `>=3.16.0 <4.0.0`. (Note: Full `flutter pub get/upgrade` was deferred due to environmental constraints).
* Added `analysis_options.yaml` with `flutter_lints` and additional `effective_dart` rules to enforce stricter code quality.
2. **Core Refactoring:**
* **`WeatherProvider`**: Made `weather` and `additionalWeatherData` nullable, improved URI construction to use `Uri.https` and query maps, enhanced error handling with `debugPrint` and safer JSON parsing, and addressed `use_build_context_synchronously` warnings.
* **`HomeScreen`**: Applied `const` and `final` where appropriate, refactored widget construction for clarity.
3. **Theming & UI/UX Enhancements:**
* **Centralized Theme**: Refined `ThemeData` in `main.dart` with a complete `ColorScheme`, standardized text styles (removing hardcoded colors from `textStyle.dart`), and defined a global `dividerTheme`. Added new theme colors in `colors.dart`.
* **Widget Styling**: Updated various widgets (`WeatherInfoHeader`, `MainWeatherInfo`, `MainWeatherDetail`, `SevenDayForecast`, `TwentyFourHourForecast`) to:
* Use themed colors and divider styles.
* Improve text readability by adjusting font weights.
* Standardize spacing for better visual consistency.
4. **Testing Preparation:**
* The default counter test was identified as irrelevant.
* Key areas for future unit and widget tests were noted, emphasizing `WeatherProvider` logic and UI component rendering.
These changes aim to create a more robust, maintainable, and visually appealing application foundation. Further testing and dependency upgrades should be performed in a compatible Flutter environment.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Generic High Entropy Secret | acba750 | lib/provider/weatherProvider.dart | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.