Skip to content

feat(mcp-js): move instrumentation to transport layer #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeldking merged 5 commits into from
Apr 24, 2025
Merged

feat(mcp-js): move instrumentation to transport layer #1555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
adaa7c7
feat(mcp-js): move instrumentation to transport layer
anuraaga Apr 24, 2025
0e64552
Case
anuraaga Apr 24, 2025
c7efe62
Lint
anuraaga Apr 24, 2025
d36ea66
Drift
anuraaga Apr 24, 2025
db2daa2
Update README
anuraaga Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions js/packages/openinference-instrumentation-mcp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,22 @@ To load the MCP instrumentation, manually instrument the `@modelcontextprotocol/
The client and server must be manually instrumented due to the non-traditional module structure in `@modelcontextprotocol/sdk`. Additional instrumentations can
be registered as usual using the `registerInstrumentations` function.

For example, if using stdio transport,

```typescript
import { NodeTracerProvider } from "@opentelemetry/sdk-trace-node";
import { MCPInstrumentation } from "@arizeai/openinference-instrumentation-mcp";
import * as MCPClientModule from "@modelcontextprotocol/sdk/client/index";
import * as MCPServerModule from "@modelcontextprotocol/sdk/server/index";
import * as MCPClientStdioModule from "@modelcontextprotocol/sdk/client/stdio";
import * as MCPServerStdioModule from "@modelcontextprotocol/sdk/server/stdio";

const provider = new NodeTracerProvider();
provider.register();

const mcpInstrumentation = new MCPInstrumentation();
// MCP must be manually instrumented as it doesn't have a traditional module structure
mcpInstrumentation.manuallyInstrument({
clientModule: MCPClientModule,
serverModule: MCPServerModule,
clientStdioModule: MCPClientStdioModule,
serverStdioModule: MCPServerStdioModule,
});
```

Expand Down
5 changes: 3 additions & 2 deletions js/packages/openinference-instrumentation-mcp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,15 @@
"license": "Apache-2.0",
"devDependencies": {
"express": "^5.1.0",
"@modelcontextprotocol/sdk": "^1.10.0",
"@modelcontextprotocol/sdk": "^1.10.2",
"@opentelemetry/exporter-trace-otlp-http": "^0.57.2",
"@opentelemetry/resources": "^1.30.1",
"@opentelemetry/sdk-trace-base": "^1.30.1",
"@opentelemetry/sdk-trace-node": "^1.30.1",
"@opentelemetry/semantic-conventions": "^1.30.1",
"@types/express": "^5.0.1",
"jest": "^29.7.0",
"tsx": "^4.19.3"
"tsx": "^4.19.3",
"zod": "^3.24.3"
}
}
Loading