Create dependency-inversion-after-comp.py #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just my simple idea how to (possibly) use composition instead of inheritance in the dependency-inversion-after.py
cclauss
reviewed
Jan 26, 2023
Comment on lines
+18
to
+21
| total = 0 | ||
| for i in range(len(self.prices)): | ||
| total += self.quantities[i] * self.prices[i] | ||
| return total |
There was a problem hiding this comment.
Suggested change
| total = 0 | |
| for i in range(len(self.prices)): | |
| total += self.quantities[i] * self.prices[i] | |
| return total | |
| return sum(quantity * price for quantity, price in zip(self.quantities, self.prices)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Arjan,
thanks a lot for your videos on YouTube, it's super helpful for me to learn more about Python. You are doing a great work to the community, really appreciating.
Here is just my simple idea how to (possibly) use composition instead of inheritance in the
dependency-inversion-after.py.Please if you have some time, could you check this code and comment what would you change (if anything) and if you think it make sense we could even merge it.
Thanks again.