Moves reset button out of navigation bar#154
Open
vreelb wants to merge 1 commit intoAsherGlick:masterfrom
Open
Moves reset button out of navigation bar#154vreelb wants to merge 1 commit intoAsherGlick:masterfrom
vreelb wants to merge 1 commit intoAsherGlick:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves "Reset Item Counts" out of the navbar and into a more contextually relevant place. Reset button is red and pops a confirm dialog before carrying out the reset.
To conserve space on mobile this also hides the
Filter:label once the screen is smaller, and placeholder text has been added to explain the function in lieu of this.Longer-term it would make sense to either explore swapping to icons on mobile or having the two buttons occupy a second row, but that can be revisited as a part of mobile-supporting work.
Before:
After:
