Fix Poetry setup #56
Merged
Fix Poetry setup #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the previously used action workflow's source code (https://github.com/abatilo/actions-poetry/blob/master/action.yml), this seems to be all it does anyway. So probably better to just do it manually and have full control, if that's all we need. This will most likely not solve the macOS issue, but at least it should make it easier to debug and fix it...
Running from Poetry to avoid any environment crape.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 7 7
=========================================
Hits 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hugobuddel
approved these changes
Aug 24, 2025
Contributor
hugobuddel
left a comment
hugobuddel
left a comment
There was a problem hiding this comment.
Good! Thanks.
(And now let's ditch everything in favor of uv?)
Contributor
Author
Nah, please don't. Already now while googling for solutions to this, half the results were quasi-advertisements for |
github-project-automation
bot
moved this from 👀 Awaiting Review
to ✅ Done
in ScopeSim-development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should now really actually (I hope) solve the recent macOS issues, by installing Poetry first and then the correct Python version, as suggested by the
actions/setup-pythondocs. I also now got rid of theabatilo/actions-poetry, that project appears abandoned by the (only) author, and after looking at the actual code, it does little more than runningpipx install poetryanyway.