Skip to content

Conversation

@teutoburg
Copy link
Contributor

Well, trying to run this with an unsupported version (setting the matrix to include 3.9, which the example project here doesn't support) now fails, which wasn't the case for any of my previous attempts. However, if you look carefully at the logs, it still installs with another Python environment (3.12 in this case), but then at least fails when trying to run the tests. So I'm classifying this as a partial success.

The root cause seems to be a bug in Poetry 😑

@teutoburg teutoburg self-assigned this Aug 31, 2025
@teutoburg teutoburg added the github_actions Pull requests that update GitHub Actions code label Aug 31, 2025
@codecov
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (949fbad) to head (93b876b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines            7         7           
=========================================
  Hits             7         7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg marked this pull request as ready for review August 31, 2025 22:31
@teutoburg teutoburg requested a review from hugobuddel August 31, 2025 22:32
Copy link
Contributor

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So we keep that line in to verify what version is being used?

@teutoburg
Copy link
Contributor Author

Indeed, or rather that was the idea of the one below poetry run python -V >> "$GITHUB_STEP_SUMMARY" I recently added. That allows us to (manually) check which python, basically. But with this new one now it also actually fails when I'd expect it to. But even if that apparent bug in Poetry is fixed, I don't see any downside in keeping both lines in.

@teutoburg teutoburg merged commit d647612 into main Sep 1, 2025
20 checks passed
@teutoburg teutoburg deleted the teutoburg-patch-1 branch September 1, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants