DRAFT : my atmospheric shift and transmission code for MOSAIC #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astronomyk
changed the title
…pose Now outputs WLs and trans for individual fibre
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev_master #203 +/- ##
==============================================
- Coverage 75.13% 74.01% -1.13%
==============================================
Files 147 149 +2
Lines 15181 15411 +230
==============================================
Hits 11406 11406
- Misses 3775 4005 +230
☔ View full report in Codecov by Sentry. |
Cleaned up the code, added more comments for clarity, fixed HR NIR mode
…e it in an Effect object
1) Added a class variable containing pd table of fibre dimensions, columns of fibre_id,dx,dy 2) Changed run function's transmission array to a dictionary with keys of fibre_id
Implemented code to generate a hexagonal aperture array for an arbitrary number of rings HR_VIS now is working as a 3-layer hexagon array can be made
Hexagonal aperture arrays were odd-sized with a central pixel This meant hexagons would leave a gap or overlap due to symmetry Fixed so that the arrays for the aperture and PSF arrays are now even-sized
teutoburg
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First contribution of MOSAIC atmopsheric shift and transmission code to SCOPESIM.
Contains class of simulation and corresponding utility functions added to the effects file.
Purpose is to include the effects of atmospheric dispersion into the transmission traces of SCOPESIM simulations, where off-set PSFs cause differential losses through observing bands. Takes in parameters such as telescope guiding, aperture centre wavelength, observation details (hour angles, declination etc.) to establish the effect.